# 2024-02-05 Triage Log

Rust's CI was down most of the week, leading to a much smaller collection of
commits than usual.

Triage done by **@simulacrum**.
Revision range: [5c9c3c7871d603ba13d38372830eca0c9013e575..0984becf01112cbd3583c796541760b65340c8db](https://perf.rust-lang.org/?start=5c9c3c7871d603ba13d38372830eca0c9013e575&end=0984becf01112cbd3583c796541760b65340c8db&absolute=false&stat=instructions%3Au)

**Summary**:

| (instructions:u)                   | mean  | range          | count |
|:----------------------------------:|:-----:|:--------------:|:-----:|
| Regressions ❌ <br /> (primary)    | -     | -              | 0     |
| Regressions ❌ <br /> (secondary)  | 0.3%  | [0.2%, 0.3%]   | 3     |
| Improvements ✅ <br /> (primary)   | -0.3% | [-0.7%, -0.2%] | 7     |
| Improvements ✅ <br /> (secondary) | -0.6% | [-1.0%, -0.5%] | 7     |
| All ❌✅ (primary)                 | -0.3% | [-0.7%, -0.2%] | 7     |


0 Regressions, 2 Improvements, 1 Mixed; 1 of them in rollups
17 artifact comparisons made in total

#### Regressions

* None this week.

#### Improvements

Normalize region obligation in lexical region resolution with next-gen solver [#119101](https://github.com/rust-lang/rust/pull/119101) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=f3d71c9249072413f014b378bb5ea79c8a7dc9a7&end=cb4d9a1902b3ea17e93872dafb76d24aa6295c47&stat=instructions:u)

| (instructions:u)                   | mean  | range          | count |
|:----------------------------------:|:-----:|:--------------:|:-----:|
| Regressions ❌ <br /> (primary)    | -     | -              | 0     |
| Regressions ❌ <br /> (secondary)  | -     | -              | 0     |
| Improvements ✅ <br /> (primary)   | -0.2% | [-0.3%, -0.2%] | 4     |
| Improvements ✅ <br /> (secondary) | -     | -              | 0     |
| All ❌✅ (primary)                 | -0.2% | [-0.3%, -0.2%] | 4     |


hir: Refactor getters for owner nodes [#120346](https://github.com/rust-lang/rust/pull/120346) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=80deabd0987201e1b8d060400f50e03309a0105e&end=d53ddcd8bbb41cd977ab4f7a54886fd7779c0eba&stat=instructions:u)

| (instructions:u)                   | mean  | range          | count |
|:----------------------------------:|:-----:|:--------------:|:-----:|
| Regressions ❌ <br /> (primary)    | -     | -              | 0     |
| Regressions ❌ <br /> (secondary)  | -     | -              | 0     |
| Improvements ✅ <br /> (primary)   | -3.6% | [-3.6%, -3.6%] | 1     |
| Improvements ✅ <br /> (secondary) | -0.6% | [-1.0%, -0.5%] | 7     |
| All ❌✅ (primary)                 | -3.6% | [-3.6%, -3.6%] | 1     |

#### Mixed

Rollup of 9 pull requests [#120660](https://github.com/rust-lang/rust/pull/120660) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=0984becf01112cbd3583c796541760b65340c8db&end=8c0b4f67c9b4bf477df38c16669fd576d46a2b3d&stat=instructions:u)

| (instructions:u)                   | mean  | range          | count |
|:----------------------------------:|:-----:|:--------------:|:-----:|
| Regressions ❌ <br /> (primary)    | 0.8%  | [0.2%, 1.4%]   | 2     |
| Regressions ❌ <br /> (secondary)  | -     | -              | 0     |
| Improvements ✅ <br /> (primary)   | -     | -              | 0     |
| Improvements ✅ <br /> (secondary) | -0.2% | [-0.3%, -0.2%] | 2     |
| All ❌✅ (primary)                 | 0.8%  | [0.2%, 1.4%]   | 2     |

Needs further investigation. This just landed so it's hard to say whether the
regressions are noise or not. Kicked off another run on the PR to see if that
helps.
